[llvm] InstCombine/test: cover foldSelectValueEquivalence (PR #111694)
Ramkumar Ramachandra via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 9 08:10:17 PDT 2024
https://github.com/artagnon created https://github.com/llvm/llvm-project/pull/111694
Write dedicated tests for foldSelectValueEquivalence, demonstrating that it does not perform many GVN-like replacements on vector-values, as a prelude to fixing this deficiency.
>From 19032b5de3b40fc22b252cf50991d4e9cce27621 Mon Sep 17 00:00:00 2001
From: Ramkumar Ramachandra <ramkumar.ramachandra at codasip.com>
Date: Wed, 9 Oct 2024 16:05:16 +0100
Subject: [PATCH] InstCombine/test: cover foldSelectValueEquivalence
Write dedicated tests for foldSelectValueEquivalence, demonstrating that
it does not perform many GVN-like replacements on vector-values, as a
prelude to fixing this deficiency.
---
.../InstCombine/select-value-equivalence.ll | 183 ++++++++++++++++++
1 file changed, 183 insertions(+)
create mode 100644 llvm/test/Transforms/InstCombine/select-value-equivalence.ll
diff --git a/llvm/test/Transforms/InstCombine/select-value-equivalence.ll b/llvm/test/Transforms/InstCombine/select-value-equivalence.ll
new file mode 100644
index 00000000000000..c8224e3b607404
--- /dev/null
+++ b/llvm/test/Transforms/InstCombine/select-value-equivalence.ll
@@ -0,0 +1,183 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt -passes=instcombine -S %s | FileCheck %s
+
+define <2 x i8> @select_icmp_insertelement_eq(<2 x i8> %x, <2 x i8> %y) {
+; CHECK-LABEL: define <2 x i8> @select_icmp_insertelement_eq(
+; CHECK-SAME: <2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]]) {
+; CHECK-NEXT: [[CMP:%.*]] = icmp eq <2 x i8> [[Y]], <i8 2, i8 2>
+; CHECK-NEXT: [[RETVAL:%.*]] = select <2 x i1> [[CMP]], <2 x i8> <i8 2, i8 0>, <2 x i8> [[X]]
+; CHECK-NEXT: ret <2 x i8> [[RETVAL]]
+;
+ %cmp = icmp eq <2 x i8> %y, <i8 2, i8 2>
+ %insert = insertelement <2 x i8> %y, i8 0, i8 1
+ %retval = select <2 x i1> %cmp, <2 x i8> %insert, <2 x i8> %x
+ ret <2 x i8> %retval
+}
+
+define <2 x i8> @select_icmp_insertelement_ne(<2 x i8> %x, <2 x i8> %y) {
+; CHECK-LABEL: define <2 x i8> @select_icmp_insertelement_ne(
+; CHECK-SAME: <2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]]) {
+; CHECK-NEXT: [[CMP_NOT:%.*]] = icmp eq <2 x i8> [[Y]], <i8 2, i8 2>
+; CHECK-NEXT: [[RETVAL:%.*]] = select <2 x i1> [[CMP_NOT]], <2 x i8> <i8 2, i8 0>, <2 x i8> [[X]]
+; CHECK-NEXT: ret <2 x i8> [[RETVAL]]
+;
+ %cmp = icmp ne <2 x i8> %y, <i8 2, i8 2>
+ %insert = insertelement <2 x i8> %y, i8 0, i8 1
+ %retval = select <2 x i1> %cmp, <2 x i8> %x, <2 x i8> %insert
+ ret <2 x i8> %retval
+}
+
+define <2 x i8> @select_icmp_shufflevector(<2 x i8> %x, <2 x i8> %y) {
+; CHECK-LABEL: define <2 x i8> @select_icmp_shufflevector(
+; CHECK-SAME: <2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]]) {
+; CHECK-NEXT: [[CMP:%.*]] = icmp eq <2 x i8> [[Y]], <i8 2, i8 2>
+; CHECK-NEXT: [[SHUFFLE:%.*]] = shufflevector <2 x i8> [[Y]], <2 x i8> poison, <2 x i32> <i32 1, i32 0>
+; CHECK-NEXT: [[RETVAL:%.*]] = select <2 x i1> [[CMP]], <2 x i8> [[SHUFFLE]], <2 x i8> [[X]]
+; CHECK-NEXT: ret <2 x i8> [[RETVAL]]
+;
+ %cmp = icmp eq <2 x i8> %y, <i8 2, i8 2>
+ %shuffle = shufflevector <2 x i8> %y, <2 x i8> poison, <2 x i32> <i32 1, i32 0>
+ %retval = select <2 x i1> %cmp, <2 x i8> %shuffle, <2 x i8> %x
+ ret <2 x i8> %retval
+}
+
+define <2 x i8> @select_icmp_udiv_vec(<2 x i8> %x, <2 x i8> %y) {
+; CHECK-LABEL: define <2 x i8> @select_icmp_udiv_vec(
+; CHECK-SAME: <2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]]) {
+; CHECK-NEXT: [[CMP:%.*]] = icmp eq <2 x i8> [[Y]], <i8 2, i8 2>
+; CHECK-NEXT: [[UDIV:%.*]] = udiv <2 x i8> [[X]], [[Y]]
+; CHECK-NEXT: [[RETVAL:%.*]] = select <2 x i1> [[CMP]], <2 x i8> [[UDIV]], <2 x i8> [[X]]
+; CHECK-NEXT: ret <2 x i8> [[RETVAL]]
+;
+ %cmp = icmp eq <2 x i8> %y, <i8 2, i8 2>
+ %udiv = udiv <2 x i8> %x, %y
+ %retval = select <2 x i1> %cmp, <2 x i8> %udiv, <2 x i8> %x
+ ret <2 x i8> %retval
+}
+
+define <2 x i8> @select_icmp_urem_vec(<2 x i8> %x, <2 x i8> %y) {
+; CHECK-LABEL: define <2 x i8> @select_icmp_urem_vec(
+; CHECK-SAME: <2 x i8> [[X:%.*]], <2 x i8> [[Y:%.*]]) {
+; CHECK-NEXT: [[CMP:%.*]] = icmp eq <2 x i8> [[Y]], <i8 2, i8 2>
+; CHECK-NEXT: [[UREM:%.*]] = urem <2 x i8> [[X]], [[Y]]
+; CHECK-NEXT: [[RETVAL:%.*]] = select <2 x i1> [[CMP]], <2 x i8> [[UREM]], <2 x i8> [[X]]
+; CHECK-NEXT: ret <2 x i8> [[RETVAL]]
+;
+ %cmp = icmp eq <2 x i8> %y, <i8 2, i8 2>
+ %urem = urem <2 x i8> %x, %y
+ %retval = select <2 x i1> %cmp, <2 x i8> %urem, <2 x i8> %x
+ ret <2 x i8> %retval
+}
+
+define <2 x double> @select_fcmp_fdiv_oeq_not_zero_vec(<2 x double> %x, <2 x double> %y) {
+; CHECK-LABEL: define <2 x double> @select_fcmp_fdiv_oeq_not_zero_vec(
+; CHECK-SAME: <2 x double> [[X:%.*]], <2 x double> [[Y:%.*]]) {
+; CHECK-NEXT: [[FCMP:%.*]] = fcmp oeq <2 x double> [[Y]], <double 2.000000e+00, double 2.000000e+00>
+; CHECK-NEXT: [[DIV:%.*]] = fdiv <2 x double> [[X]], [[Y]]
+; CHECK-NEXT: [[RETVAL:%.*]] = select <2 x i1> [[FCMP]], <2 x double> [[DIV]], <2 x double> [[X]]
+; CHECK-NEXT: ret <2 x double> [[RETVAL]]
+;
+ %fcmp = fcmp oeq <2 x double> %y, <double 2.0, double 2.0>
+ %div = fdiv <2 x double> %x, %y
+ %retval = select <2 x i1> %fcmp, <2 x double> %div, <2 x double> %x
+ ret <2 x double> %retval
+}
+
+define <2 x double> @select_fcmp_fdiv_une_not_zero_vec(<2 x double> %x, <2 x double> %y) {
+; CHECK-LABEL: define <2 x double> @select_fcmp_fdiv_une_not_zero_vec(
+; CHECK-SAME: <2 x double> [[X:%.*]], <2 x double> [[Y:%.*]]) {
+; CHECK-NEXT: [[FCMP:%.*]] = fcmp une <2 x double> [[Y]], <double 2.000000e+00, double 2.000000e+00>
+; CHECK-NEXT: [[DIV:%.*]] = fdiv <2 x double> [[X]], [[Y]]
+; CHECK-NEXT: [[RETVAL:%.*]] = select <2 x i1> [[FCMP]], <2 x double> [[X]], <2 x double> [[DIV]]
+; CHECK-NEXT: ret <2 x double> [[RETVAL]]
+;
+ %fcmp = fcmp une <2 x double> %y, <double 2.0, double 2.0>
+ %div = fdiv <2 x double> %x, %y
+ %retval = select <2 x i1> %fcmp, <2 x double> %x, <2 x double> %div
+ ret <2 x double> %retval
+}
+
+define <2 x double> @select_fcmp_fdiv_ueq_nnan_not_zero_vec(<2 x double> %x, <2 x double> %y) {
+; CHECK-LABEL: define <2 x double> @select_fcmp_fdiv_ueq_nnan_not_zero_vec(
+; CHECK-SAME: <2 x double> [[X:%.*]], <2 x double> [[Y:%.*]]) {
+; CHECK-NEXT: [[FCMP:%.*]] = fcmp nnan ueq <2 x double> [[Y]], <double 2.000000e+00, double 2.000000e+00>
+; CHECK-NEXT: [[DIV:%.*]] = fdiv <2 x double> [[X]], [[Y]]
+; CHECK-NEXT: [[RETVAL:%.*]] = select <2 x i1> [[FCMP]], <2 x double> [[DIV]], <2 x double> [[X]]
+; CHECK-NEXT: ret <2 x double> [[RETVAL]]
+;
+ %fcmp = fcmp nnan ueq <2 x double> %y, <double 2.0, double 2.0>
+ %div = fdiv <2 x double> %x, %y
+ %retval = select <2 x i1> %fcmp, <2 x double> %div, <2 x double> %x
+ ret <2 x double> %retval
+}
+
+define <2 x double> @select_fcmp_fdiv_one_nnan_not_zero_vec(<2 x double> %x, <2 x double> %y) {
+; CHECK-LABEL: define <2 x double> @select_fcmp_fdiv_one_nnan_not_zero_vec(
+; CHECK-SAME: <2 x double> [[X:%.*]], <2 x double> [[Y:%.*]]) {
+; CHECK-NEXT: [[FCMP:%.*]] = fcmp nnan one <2 x double> [[Y]], <double 2.000000e+00, double 2.000000e+00>
+; CHECK-NEXT: [[DIV:%.*]] = fdiv <2 x double> [[X]], [[Y]]
+; CHECK-NEXT: [[RETVAL:%.*]] = select <2 x i1> [[FCMP]], <2 x double> [[X]], <2 x double> [[DIV]]
+; CHECK-NEXT: ret <2 x double> [[RETVAL]]
+;
+ %fcmp = fcmp nnan one <2 x double> %y, <double 2.0, double 2.0>
+ %div = fdiv <2 x double> %x, %y
+ %retval = select <2 x i1> %fcmp, <2 x double> %x, <2 x double> %div
+ ret <2 x double> %retval
+}
+
+define <2 x double> @select_fcmp_fdiv_ueq_vec(<2 x double> %x, <2 x double> %y) {
+; CHECK-LABEL: define <2 x double> @select_fcmp_fdiv_ueq_vec(
+; CHECK-SAME: <2 x double> [[X:%.*]], <2 x double> [[Y:%.*]]) {
+; CHECK-NEXT: [[FCMP:%.*]] = fcmp ueq <2 x double> [[Y]], <double 2.000000e+00, double 2.000000e+00>
+; CHECK-NEXT: [[DIV:%.*]] = fdiv <2 x double> [[X]], [[Y]]
+; CHECK-NEXT: [[RETVAL:%.*]] = select <2 x i1> [[FCMP]], <2 x double> [[DIV]], <2 x double> [[X]]
+; CHECK-NEXT: ret <2 x double> [[RETVAL]]
+;
+ %fcmp = fcmp ueq <2 x double> %y, <double 2.0, double 2.0>
+ %div = fdiv <2 x double> %x, %y
+ %retval = select <2 x i1> %fcmp, <2 x double> %div, <2 x double> %x
+ ret <2 x double> %retval
+}
+
+define <2 x double> @select_fcmp_fdiv_one_vec(<2 x double> %x, <2 x double> %y) {
+; CHECK-LABEL: define <2 x double> @select_fcmp_fdiv_one_vec(
+; CHECK-SAME: <2 x double> [[X:%.*]], <2 x double> [[Y:%.*]]) {
+; CHECK-NEXT: [[FCMP:%.*]] = fcmp one <2 x double> [[Y]], <double 2.000000e+00, double 2.000000e+00>
+; CHECK-NEXT: [[DIV:%.*]] = fdiv <2 x double> [[X]], [[Y]]
+; CHECK-NEXT: [[RETVAL:%.*]] = select <2 x i1> [[FCMP]], <2 x double> [[X]], <2 x double> [[DIV]]
+; CHECK-NEXT: ret <2 x double> [[RETVAL]]
+;
+ %fcmp = fcmp one <2 x double> %y, <double 2.0, double 2.0>
+ %div = fdiv <2 x double> %x, %y
+ %retval = select <2 x i1> %fcmp, <2 x double> %x, <2 x double> %div
+ ret <2 x double> %retval
+}
+
+define <2 x double> @select_fcmp_fdiv_oeq_zero_vec(<2 x double> %x, <2 x double> %y) {
+; CHECK-LABEL: define <2 x double> @select_fcmp_fdiv_oeq_zero_vec(
+; CHECK-SAME: <2 x double> [[X:%.*]], <2 x double> [[Y:%.*]]) {
+; CHECK-NEXT: [[FCMP:%.*]] = fcmp oeq <2 x double> [[Y]], zeroinitializer
+; CHECK-NEXT: [[DIV:%.*]] = fdiv <2 x double> [[X]], [[Y]]
+; CHECK-NEXT: [[RETVAL:%.*]] = select <2 x i1> [[FCMP]], <2 x double> [[DIV]], <2 x double> [[X]]
+; CHECK-NEXT: ret <2 x double> [[RETVAL]]
+;
+ %fcmp = fcmp oeq <2 x double> %y, zeroinitializer
+ %div = fdiv <2 x double> %x, %y
+ %retval = select <2 x i1> %fcmp, <2 x double> %div, <2 x double> %x
+ ret <2 x double> %retval
+}
+
+define <2 x double> @select_fcmp_fdiv_une_zero_vec(<2 x double> %x, <2 x double> %y) {
+; CHECK-LABEL: define <2 x double> @select_fcmp_fdiv_une_zero_vec(
+; CHECK-SAME: <2 x double> [[X:%.*]], <2 x double> [[Y:%.*]]) {
+; CHECK-NEXT: [[FCMP:%.*]] = fcmp une <2 x double> [[Y]], zeroinitializer
+; CHECK-NEXT: [[DIV:%.*]] = fdiv <2 x double> [[X]], [[Y]]
+; CHECK-NEXT: [[RETVAL:%.*]] = select <2 x i1> [[FCMP]], <2 x double> [[X]], <2 x double> [[DIV]]
+; CHECK-NEXT: ret <2 x double> [[RETVAL]]
+;
+ %fcmp = fcmp une <2 x double> %y, zeroinitializer
+ %div = fdiv <2 x double> %x, %y
+ %retval = select <2 x i1> %fcmp, <2 x double> %x, <2 x double> %div
+ ret <2 x double> %retval
+}
+
More information about the llvm-commits
mailing list