[llvm] [InstCombine] Avoid repeated hash lookups (NFC) (PR #111618)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 19:21:00 PDT 2024


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/111618

None

>From 9d90480429ba857c0842ab0fa745b7d89ba08d0e Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Tue, 8 Oct 2024 07:37:35 -0700
Subject: [PATCH] [InstCombine] Avoid repeated hash lookups (NFC)

---
 llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp b/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
index 6c3fc987d9add2..d1eb84b5ca5c10 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
@@ -602,8 +602,9 @@ static Value *rewriteGEPAsOffset(Value *Start, Value *Base, GEPNoWrapFlags NW,
       for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
         Value *NewIncoming = PHI->getIncomingValue(I);
 
-        if (NewInsts.contains(NewIncoming))
-          NewIncoming = NewInsts[NewIncoming];
+        auto It = NewInsts.find(NewIncoming);
+        if (It != NewInsts.end())
+          NewIncoming = It->second;
 
         NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
       }



More information about the llvm-commits mailing list