[compiler-rt] [compiler-rt] Remove SHA2 interceptions for NetBSD/FreeBSD. (PR #110246)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 15:26:49 PDT 2024


================
@@ -10655,7 +10554,6 @@ static void InitializeCommonInterceptors() {
   INIT_MD5;
----------------
vitalybuka wrote:

Should we remove md5?

>From my experience interceptors, other then alloc, mem* str*, detect very few issues, however require some maintaince.
Some interceptors are unavoidable to maintan state, e.g. signals, pthread etc. For almost msan interceptors are needed. However for asan they are mostly optional.

So looking back my opinion we should rather avoid interceptor if we can.


https://github.com/llvm/llvm-project/pull/110246


More information about the llvm-commits mailing list