[llvm] [ci] Don't add a testing target for libclc (PR #111547)

David Spickett via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 08:28:29 PDT 2024


https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111547

According to https://github.com/llvm/llvm-project/pull/111369#issuecomment-2400152471 there is no testing to be done here.

Adding "check-all" only risks duplicating tests if other project specific "check-" targets are also added.

>From d051cfd2fd66909044ee75bd869e49a5c25dce15 Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at linaro.org>
Date: Tue, 8 Oct 2024 16:26:08 +0100
Subject: [PATCH] [ci] Don't add a testing target for libclc

According to https://github.com/llvm/llvm-project/pull/111369#issuecomment-2400152471
there is no testing to be done here.

Adding "check-all" only risks duplicating tests
if other project specific "check-" targets are
also added.
---
 .ci/generate-buildkite-pipeline-premerge | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.ci/generate-buildkite-pipeline-premerge b/.ci/generate-buildkite-pipeline-premerge
index 98a8b8fff3687a..17451fdedf8a56 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -219,7 +219,7 @@ function check-targets() {
       echo "check-all"
     ;;
     libclc)
-      echo "check-all"
+      # Currently there is no testing for libclc.
     ;;
     *)
       echo "check-${project}"



More information about the llvm-commits mailing list