[llvm] [LV][NFC] Improve readability with `bool` instead of `auto` (PR #111532)
Piotr Fusik via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 8 07:19:42 PDT 2024
https://github.com/pfusik updated https://github.com/llvm/llvm-project/pull/111532
>From 54fefb3b22274fab3defd123e7b7db7f0b3f1917 Mon Sep 17 00:00:00 2001
From: Piotr Fusik <p.fusik at samsung.com>
Date: Tue, 8 Oct 2024 15:56:17 +0200
Subject: [PATCH] [LV][NFC] Improve readability with `bool` instead of `auto`
---
llvm/lib/Transforms/Vectorize/LoopVectorize.cpp | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
index 001c8987667df8..8d0bb02f8af1b0 100644
--- a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
+++ b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
@@ -3204,7 +3204,7 @@ void LoopVectorizationCostModel::collectLoopScalars(ElementCount VF) {
// Determine if all users of the induction variable are scalar after
// vectorization.
- auto ScalarInd = llvm::all_of(Ind->users(), [&](User *U) -> bool {
+ bool ScalarInd = llvm::all_of(Ind->users(), [&](User *U) -> bool {
auto *I = cast<Instruction>(U);
return I == IndUpdate || !TheLoop->contains(I) || Worklist.count(I) ||
IsDirectLoadStoreFromPtrIndvar(Ind, I);
@@ -3221,7 +3221,7 @@ void LoopVectorizationCostModel::collectLoopScalars(ElementCount VF) {
// Determine if all users of the induction variable update instruction are
// scalar after vectorization.
- auto ScalarIndUpdate =
+ bool ScalarIndUpdate =
llvm::all_of(IndUpdate->users(), [&](User *U) -> bool {
auto *I = cast<Instruction>(U);
return I == Ind || !TheLoop->contains(I) || Worklist.count(I) ||
@@ -3649,11 +3649,10 @@ void LoopVectorizationCostModel::collectLoopUniforms(ElementCount VF) {
if (IsOutOfScope(V))
continue;
auto *I = cast<Instruction>(V);
- auto UsersAreMemAccesses =
- llvm::all_of(I->users(), [&](User *U) -> bool {
- auto *UI = cast<Instruction>(U);
- return TheLoop->contains(UI) && IsVectorizedMemAccessUse(UI, V);
- });
+ bool UsersAreMemAccesses = llvm::all_of(I->users(), [&](User *U) -> bool {
+ auto *UI = cast<Instruction>(U);
+ return TheLoop->contains(UI) && IsVectorizedMemAccessUse(UI, V);
+ });
if (UsersAreMemAccesses)
AddToWorklistIfAllowed(I);
}
@@ -3698,7 +3697,7 @@ void LoopVectorizationCostModel::collectLoopUniforms(ElementCount VF) {
// Determine if all users of the induction variable are uniform after
// vectorization.
- auto UniformInd = llvm::all_of(Ind->users(), [&](User *U) -> bool {
+ bool UniformInd = llvm::all_of(Ind->users(), [&](User *U) -> bool {
auto *I = cast<Instruction>(U);
return I == IndUpdate || !TheLoop->contains(I) || Worklist.count(I) ||
IsVectorizedMemAccessUse(I, Ind);
@@ -3708,7 +3707,7 @@ void LoopVectorizationCostModel::collectLoopUniforms(ElementCount VF) {
// Determine if all users of the induction variable update instruction are
// uniform after vectorization.
- auto UniformIndUpdate =
+ bool UniformIndUpdate =
llvm::all_of(IndUpdate->users(), [&](User *U) -> bool {
auto *I = cast<Instruction>(U);
return I == Ind || !TheLoop->contains(I) || Worklist.count(I) ||
More information about the llvm-commits
mailing list