[llvm] [ci] Use check-compiler-rt target for testing compiler-rt (PR #111515)

David Spickett via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 8 03:15:27 PDT 2024


https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111515

Instead of "check-all" which leads to us running some tests twice if there are other "check-..." targets. For example on one of my PRs this script produced:
```
commands:
  - './.ci/monolithic-linux.sh "clang;clang;lld;clang-tools-extra;compiler-rt;llvm" "check-all check-clang check-clang-tools" "libcxx;libcxxabi;libunwind" "check-cxx check-cxxabi check-unwind"'
  commands:
  - 'C:\BuildTools\Common7\Tools\VsDevCmd.bat -arch=amd64 -host_arch=amd64'
  - 'bash .ci/monolithic-windows.sh "clang;clang-tools-extra;llvm" "check-clang check-clang-tools"'
```
Which meant that Linux ran the clang and clang-tools tests twice. These extra tests were about 24% of the test run and increased testing time (on my local machine) by 45%.

This problem can also happen with other projects but there isn't a simple fix like this one at the moment.
* pstl has a check-pstl target but it is not part of check-all and when I tried it locally I couldn't build it.
* libclc has no check- target.

I will deal with those projects later.

>From af8e241c6a38737e15a99a4df79f7f683c2e88f0 Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at linaro.org>
Date: Tue, 8 Oct 2024 11:12:14 +0100
Subject: [PATCH] [ci] Use check-compiler-rt target for testing compiler-rt

Instead of "check-all" which leads to us running some tests twice
if there are other "check-..." targets. For example on one of my
PRs this script produced:
```
commands:
  - './.ci/monolithic-linux.sh "clang;clang;lld;clang-tools-extra;compiler-rt;llvm" "check-all check-clang check-clang-tools" "libcxx;libcxxabi;libunwind" "check-cxx check-cxxabi check-unwind"'
  commands:
  - 'C:\BuildTools\Common7\Tools\VsDevCmd.bat -arch=amd64 -host_arch=amd64'
  - 'bash .ci/monolithic-windows.sh "clang;clang-tools-extra;llvm" "check-clang check-clang-tools"'
```
Which meant that Linux ran the clang and clang-tools tests twice.
These extra tests were about 24% of the test run and increased testing time
(on my local machine) by 45%.

This problem can also happen with other projects but there isn't a
simple fix like this one at the moment.
* pstl has a check-pstl target but it is not part of check-all
  and when I tried it locally I couldn't build it.
* libclc has no check- target.

I will deal with those projects later.
---
 .ci/generate-buildkite-pipeline-premerge | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.ci/generate-buildkite-pipeline-premerge b/.ci/generate-buildkite-pipeline-premerge
index 98a8b8fff3687a..29e4458610ce66 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -198,7 +198,7 @@ function check-targets() {
       echo "check-clang-tools"
     ;;
     compiler-rt)
-      echo "check-all"
+      echo "check-compiler-rt"
     ;;
     cross-project-tests)
       echo "check-cross-project"



More information about the llvm-commits mailing list