[llvm] 1ad3180 - [llvm-remarkutil] Simplify code with std::map::operator[] (NFC) (#111407)

via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 7 21:46:45 PDT 2024


Author: Kazu Hirata
Date: 2024-10-07T21:46:41-07:00
New Revision: 1ad3180b4a07ccf7cc371882c4e10ec2667adea8

URL: https://github.com/llvm/llvm-project/commit/1ad3180b4a07ccf7cc371882c4e10ec2667adea8
DIFF: https://github.com/llvm/llvm-project/commit/1ad3180b4a07ccf7cc371882c4e10ec2667adea8.diff

LOG: [llvm-remarkutil] Simplify code with std::map::operator[] (NFC) (#111407)

Added: 
    

Modified: 
    llvm/tools/llvm-remarkutil/RemarkCounter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-remarkutil/RemarkCounter.cpp b/llvm/tools/llvm-remarkutil/RemarkCounter.cpp
index dc0685f342886a..2d9432e41d9c06 100644
--- a/llvm/tools/llvm-remarkutil/RemarkCounter.cpp
+++ b/llvm/tools/llvm-remarkutil/RemarkCounter.cpp
@@ -198,12 +198,8 @@ void ArgumentCounter::collect(const Remark &Remark) {
 }
 
 void RemarkCounter::collect(const Remark &Remark) {
-  std::optional<std::string> Key = getGroupByKey(Remark);
-  if (!Key.has_value())
-    return;
-  auto Iter = CountedByRemarksMap.insert({*Key, 1});
-  if (!Iter.second)
-    Iter.first->second += 1;
+  if (std::optional<std::string> Key = getGroupByKey(Remark))
+    ++CountedByRemarksMap[*Key];
 }
 
 Error ArgumentCounter::print(StringRef OutputFileName) {


        


More information about the llvm-commits mailing list