[llvm] [AMDGPU] Increase inline threshold when the callee only has one live use (PR #111311)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 7 11:58:15 PDT 2024


nikic wrote:

> > I'm a bit confused here. This already exists in the form of a cost bonus in the generic inlining cost model.
> > Is the point here that you want to effectively double the bonus by both applying it as a bonus in the generic model and as a threshold adjustment in AMDGPU TTI?
> 
> Yes. IIUC, the generic model doesn't seem to have a target dependent approach to adjust the bonus. The default value is not sufficient and we want to inline it regardless.

I think it would be cleaner to make that bonus configurable via TTI. Splitting it across two places is pretty confusing...

https://github.com/llvm/llvm-project/pull/111311


More information about the llvm-commits mailing list