[llvm] [test] Disable makeAllowedFCmpRegion due to taking too long (PR #111056)

Yingwei Zheng via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 4 19:52:18 PDT 2024


dtcxzyw wrote:

```
|--90.39%--(anonymous namespace)::ConstantFPRangeTest_makeAllowedFCmpRegion_Test::TestBody()::{lambda(llvm::ConstantFPRange const&)#1}::operator()(llvm::ConstantFPRange const&) const::{lambda(llvm::APFloat const&)#1}::operator()
                          |                                |          |          
                          |                                |          |--74.99%--(anonymous namespace)::AnyOfValueInConstantFPRange<(anonymous namespace)::ConstantFPRangeTest_makeAllowedFCmpRegion_Test::TestBody()::{lambda(llvm::ConstantFPRange const&)#1}::operator()(llvm::ConstantFPRange const&) const::{lambda(llvm::APFloat const&)#1}::operator()(llvm::APFloat const) const::{lambda(llvm::APFloat const)#1}>
                          |                                |          |          |          
                          |                                |          |          |--56.08%--bool (anonymous namespace)::AnyOfValueInConstantFPRange<(anonymous namespace)::ConstantFPRangeTest_makeAllowedFCmpRegion_Test::TestBody()::{lambda(llvm::ConstantFPRange const&)#1}::operator()(llvm::ConstantFPRange const&) const::{lambda(llvm::APFloat const&)#1}::operator()(llvm::APFloat const) const::{lambda(llvm::APFloat const)#1}>(llvm::ConstantFPRange const&, (anonymous namespace)::ConstantFPRangeTest_makeAllowedFCmpRegion_Test::TestBody()::{lambda(llvm::ConstantFPRange const&)#1}::operator()(llvm::ConstantFPRange const&) const::{lambda(llvm::APFloat const&)#1}::operator()(llvm::APFloat const) const::{lambda(llvm::APFloat const)#1}, bool)::{lambda({lambda(llvm::ConstantFPRange const&)#1}&)#1}::operator()
                          |                                |          |          |          |          
                          |                                |          |          |          |--46.40%--(anonymous namespace)::strictNext
                          |                                |          |          |          |          |          
                          |                                |          |          |          |          |--40.51%--llvm::APFloat::next
```

I cannot make it faster. I tried to cache the result of `strictNext`. But it took ~50% more time than before :(

> EXPENSIVE_CHECKS maybe?

How about using `__OPTIMIZE__/_DEBUG` as we does for `LLVM_IS_DEBUG_BUILD`?
https://github.com/llvm/llvm-project/blob/e6549b8036089f20c6ac01e644a544aa2b231ca8/llvm/lib/Support/CommandLine.cpp#L2501-L2542

https://github.com/llvm/llvm-project/pull/111056


More information about the llvm-commits mailing list