[llvm] [LLVM][TableGen] Check overloaded intrinsic mangling suffix conflicts (PR #110324)

Rahul Joshi via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 4 15:44:31 PDT 2024


jurahul wrote:

@nikic and @arsenm, I am thinking if the current approach is too complex, may be a simpler check with an opt-out property on the intrinsic for intrinsics where we know it's safe is the alternative to pursue, as opposed to a hard coded list of whitelisted intrinsic names in the `IntrinsicEmitter.cpp` file. Along with the property that we will add, we will add a comment describing when exactly there could be a conflict. That means any new intrinsics added will get opted in into this check and folks have to actively opt-opt once they verify its safe. The property can be called `[NoOverloadNameConflict]` (or better name welcome) and will be added to `Intrinsics.td`. Please let me know if that sounds like a reasonable approach. I'll report here how many intrinsics we expect to tag with this to get them grandfathered in.

https://github.com/llvm/llvm-project/pull/110324


More information about the llvm-commits mailing list