vporpo wrote: > A refactor is getting a little past NFC, but otherwise fine. Yeah NFC in the sense that the high-level functionality does won't change, but I think you are right. https://github.com/llvm/llvm-project/pull/110730