[llvm] [test] Disable makeAllowedFCmpRegion due to taking too long (PR #111056)

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 13:20:57 PDT 2024


https://github.com/aeubanks created https://github.com/llvm/llvm-project/pull/111056

This was added in #110082. It takes 32s in an optimized build of LLVM, and doesn't finish after multiple minutes in an -O0 build. It's iterating all possible fp values 3 levels deep. Disable until the test is fixed to not take so much time.

>From e0dbe084750b81754e70e1b6c64c0a5483e3862d Mon Sep 17 00:00:00 2001
From: Arthur Eubanks <aeubanks at google.com>
Date: Thu, 3 Oct 2024 20:17:48 +0000
Subject: [PATCH] [test] Disable makeAllowedFCmpRegion due to taking too long

This was added in #110082. It takes 32s in an optimized build of LLVM,
and doesn't finish after multiple minutes in an -O0 build. It's
iterating all possible fp values 3 levels deep. Disable until the
test is fixed to not take so much time.
---
 llvm/unittests/IR/ConstantFPRangeTest.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/llvm/unittests/IR/ConstantFPRangeTest.cpp b/llvm/unittests/IR/ConstantFPRangeTest.cpp
index 17a08207fe1ba0..ae0ea8069fff5f 100644
--- a/llvm/unittests/IR/ConstantFPRangeTest.cpp
+++ b/llvm/unittests/IR/ConstantFPRangeTest.cpp
@@ -443,6 +443,9 @@ TEST_F(ConstantFPRangeTest, MismatchedSemantics) {
 #endif
 
 TEST_F(ConstantFPRangeTest, makeAllowedFCmpRegion) {
+  // TODO: reenable once test is fixed to run more quickly.
+  GTEST_SKIP();
+
   for (auto Pred : FCmpInst::predicates()) {
     EnumerateConstantFPRanges(
         [Pred](const ConstantFPRange &CR) {



More information about the llvm-commits mailing list