[llvm] [DebugInfo][InstCombine] Do not overwrite prior DILocation for new Insts (PR #108565)

Jeremy Morse via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 3 07:19:54 PDT 2024


https://github.com/jmorse approved this pull request.

LGTM but with the dumbest nit: it looks like the test is checking we get line number 63, instead of line number 64, which is fine. Could we replace the line numbers with something much more obvious, such as line number 1 to line number 55555 perhaps: IMO it makes the test much more readable and the relevant parts stand out.

https://github.com/llvm/llvm-project/pull/108565


More information about the llvm-commits mailing list