[compiler-rt] [llvm] Add explicit symbol visibility macros to InstrProfData.inc (PR #110732)

Thomas Fransham via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 2 21:56:28 PDT 2024


================
@@ -62,6 +62,15 @@
 #define INSTR_PROF_VISIBILITY
 #endif
 
+/* This is include is needed for symbol visibility macros used on
----------------
fsfod wrote:

so the comment should be by both the classes annotated with the macro from that header instead?

I should add the build failure will need a lot more code merged to trigger, but i wanted to give some context to this change.
This is the linker error:
```
ld.lld: error: undefined symbol: llvm::EnableABIBreakingChecks
>>> referenced by FindBugs.cpp
>>>               tools/bugpoint/CMakeFiles/bugpoint.dir/FindBugs.cpp.o:(.data._ZN4llvm29VerifyEnableABIBreakingChecksE+0x0)
>>> referenced by OptimizerDriver.cpp
>>>               tools/bugpoint/CMakeFiles/bugpoint.dir/OptimizerDriver.cpp.o:(.data._ZN4llvm29VerifyEnableABIBreakingChecksE+0x0)
>>> referenced by BugDriver.cpp
>>>               tools/bugpoint/CMakeFiles/bugpoint.dir/BugDriver.cpp.o:(llvm::VerifyEnableABIBreakingChecks)
```

https://github.com/llvm/llvm-project/pull/110732


More information about the llvm-commits mailing list