[llvm] [EarlyCSE] De-Duplicate callsites with differing attrs (PR #110929)
Yingwei Zheng via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 2 20:03:52 PDT 2024
================
@@ -1632,6 +1632,9 @@ bool EarlyCSE::processNode(DomTreeNode *Node) {
LLVM_DEBUG(dbgs() << "Skipping due to debug counter\n");
continue;
}
+
+ // Potential TODO: We may be throwing away attribute information when
+ // we delete Inst that we could propagate too InVal.first.
----------------
dtcxzyw wrote:
I suspect we will run into correctness issues if we don't combine the attributes after CSE. But I cannot think of a counterexample right now.
```suggestion
// we delete Inst that we could propagate to InVal.first.
```
https://github.com/llvm/llvm-project/pull/110929
More information about the llvm-commits
mailing list