[llvm] [Offload] Introduce offload-tblgen and initial new API implementation (PR #108413)

Joseph Huber via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 2 11:16:44 PDT 2024


jhuber6 wrote:

> I don't understand why you check in auto-generated code. It is a common anti-pattern. You should instead make tblgen a build dependency. It is the common approach in the rest of the project. If you run e.g. `ninja llc`, there will be lot of tblgen invocations if the output was not generated in a previous run.

The main concern here is just that it's really difficult to review changes since we don't see the header (Since this is an API header the user will read and not just some implementation detail). I can see it either way honestly, it's just tough to review without seeing the changes.

https://github.com/llvm/llvm-project/pull/108413


More information about the llvm-commits mailing list