[llvm] [AArch64][BOLT] Ensure tentative code layout for cold BBs runs. (PR #96609)

Vladislav Khmelevsky via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 1 12:29:55 PDT 2024


================
@@ -382,6 +382,13 @@ uint64_t LongJmpPass::tentativeLayoutRelocMode(
     DotAddress += Func->estimateConstantIslandSize();
     ++CurrentIndex;
   }
+
+  // Ensure that tentative code layout always runs for cold blocks.
+  if (!ColdLayoutDone)
+    runColdLayout();
+  assert(ColdLayoutDone &&
----------------
yota9 wrote:

It seems this assert is redundant and could not be raised by anything, I suggest to remove it

https://github.com/llvm/llvm-project/pull/96609


More information about the llvm-commits mailing list