[llvm] Scalarizer: Replace cl::opts with pass parameters (PR #110645)

via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 1 12:01:24 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 2d3119c3d914467c350902c6532443b53d1715d3 d3a3cf2895881d0ec2fb32bf14265fde1b4ada57 --extensions h,cpp -- llvm/include/llvm/Transforms/Scalar/Scalarizer.h llvm/lib/Passes/PassBuilder.cpp llvm/lib/Target/DirectX/DirectXTargetMachine.cpp llvm/lib/Transforms/Scalar/Scalarizer.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Passes/PassBuilder.cpp b/llvm/lib/Passes/PassBuilder.cpp
index c3429c8d68..19cb9f9150 100644
--- a/llvm/lib/Passes/PassBuilder.cpp
+++ b/llvm/lib/Passes/PassBuilder.cpp
@@ -1072,14 +1072,15 @@ Expected<ScalarizerPassOptions> parseScalarizerOptions(StringRef Params) {
     else if (ParamName == "variable-insert-extract")
       Result.ScalarizeVariableInsertExtract = Enable;
     else
-    } else {
-      return make_error<StringError>(
-          formatv("invalid Scalarizer pass parameter '{0}' ", ParamName).str(),
-          inconvertibleErrorCode());
-    }
   }
+  else {
+    return make_error<StringError>(
+        formatv("invalid Scalarizer pass parameter '{0}' ", ParamName).str(),
+        inconvertibleErrorCode());
+  }
+}
 
-  return Result;
+return Result;
 }
 
 Expected<SROAOptions> parseSROAOptions(StringRef Params) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/110645


More information about the llvm-commits mailing list