[llvm] [X86] Don't request 0x90 nop filling in p2align directives (PR #110134)

Jeremy Morse via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 1 10:46:52 PDT 2024


jmorse wrote:

Thanks for the reviews; I've added a {{$}} to same-align-bytes-with-llasm-llobj.ll to ensure there are no trailing operands to p2align, and removed the now redundant assignments to TextAlignFillValue

> Also, sorry for the behaviour divergence. I'm glad I timed my PR to land just after branching so we had time to find issues like this

Timing greatly appreciated, this did indeed take a decent period to filter through to the right tests.

https://github.com/llvm/llvm-project/pull/110134


More information about the llvm-commits mailing list