[llvm] [RISCV] Add 32 bit GPR sub-register for Zfinx. (PR #108336)
Alex Bradbury via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 1 06:59:08 PDT 2024
================
@@ -723,9 +772,18 @@ bool llvm::CC_RISCV_GHC(unsigned ValNo, MVT ValVT, MVT LocVT,
}
}
- if ((LocVT == MVT::f32 && Subtarget.hasStdExtZfinx()) ||
- (LocVT == MVT::f64 && Subtarget.hasStdExtZdinx() &&
- Subtarget.is64Bit())) {
+ if (LocVT == MVT::f32 && Subtarget.hasStdExtZfinx()) {
----------------
asb wrote:
Not really an issue for this review directly, but I wonder if we should be more aggressive about erroring out of the GHC calling convention for more obscure targets that are unlikely to ever need it. Is the ghc cc realistically ever going to be needed on a zfinx/zdinx system?
Change looks fine though.
https://github.com/llvm/llvm-project/pull/108336
More information about the llvm-commits
mailing list