[llvm] [llvm][Coroutines] Avoid Type::getPointerTo() (NFC) (PR #110520)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 30 08:13:13 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-transforms
Author: Youngsuk Kim (JOE1994)
<details>
<summary>Changes</summary>
`llvm::Type::getPointerTo()` is to be deprecated & removed soon.
In `Lowerer::lowerCoroDone`, also remove the no-op bitcast (1st parameter of `llvm::coro::done` intrinsic is `ptr`).
---
Full diff: https://github.com/llvm/llvm-project/pull/110520.diff
1 Files Affected:
- (modified) llvm/lib/Transforms/Coroutines/CoroEarly.cpp (+4-9)
``````````diff
diff --git a/llvm/lib/Transforms/Coroutines/CoroEarly.cpp b/llvm/lib/Transforms/Coroutines/CoroEarly.cpp
index 5f8efd1a8f32ea..093a81648c92e1 100644
--- a/llvm/lib/Transforms/Coroutines/CoroEarly.cpp
+++ b/llvm/lib/Transforms/Coroutines/CoroEarly.cpp
@@ -34,9 +34,7 @@ class Lowerer : public coro::LowererBase {
public:
Lowerer(Module &M)
: LowererBase(M), Builder(Context),
- AnyResumeFnPtrTy(FunctionType::get(Type::getVoidTy(Context), Int8Ptr,
- /*isVarArg=*/false)
- ->getPointerTo()) {}
+ AnyResumeFnPtrTy(PointerType::getUnqual(Context)) {}
void lowerEarlyIntrinsics(Function &F);
};
}
@@ -91,11 +89,9 @@ void Lowerer::lowerCoroDone(IntrinsicInst *II) {
static_assert(coro::Shape::SwitchFieldIndex::Resume == 0,
"resume function not at offset zero");
auto *FrameTy = Int8Ptr;
- PointerType *FramePtrTy = FrameTy->getPointerTo();
Builder.SetInsertPoint(II);
- auto *BCI = Builder.CreateBitCast(Operand, FramePtrTy);
- auto *Load = Builder.CreateLoad(FrameTy, BCI);
+ auto *Load = Builder.CreateLoad(FrameTy, Operand);
auto *Cond = Builder.CreateICmpEQ(Load, NullPtr);
II->replaceAllUsesWith(Cond);
@@ -128,10 +124,9 @@ void Lowerer::lowerCoroNoop(IntrinsicInst *II) {
// Create a noop.frame struct type.
StructType *FrameTy = StructType::create(C, "NoopCoro.Frame");
- auto *FramePtrTy = FrameTy->getPointerTo();
- auto *FnTy = FunctionType::get(Type::getVoidTy(C), FramePtrTy,
+ auto *FnTy = FunctionType::get(Type::getVoidTy(C), Builder.getPtrTy(0),
/*isVarArg=*/false);
- auto *FnPtrTy = FnTy->getPointerTo();
+ auto *FnPtrTy = Builder.getPtrTy(0);
FrameTy->setBody({FnPtrTy, FnPtrTy});
// Create a Noop function that does nothing.
``````````
</details>
https://github.com/llvm/llvm-project/pull/110520
More information about the llvm-commits
mailing list