[llvm] [AArch64] Consistently use EmitToStreamer across the AArch64AsmPrinter (PR #110107)
David Sherwood via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 30 06:41:26 PDT 2024
david-arm wrote:
> Thank you for the review!
>
> > As you are adding a new function, it's good time to fix the naming case to `emitToStreamer`
>
> I think renaming `EmitToStreamer` to `emitToStreamer` now may be a bit error-prone, as this function overrides the non-virtual `AsmPrinter::EmitToStreamer`, so in `AArch64AsmParser` there would be two different functions accessible with almost identical names and almost identical implementations.
Yeah I agree, and the alternative would be having the single argument emitToStreamer function call EmitToStreamer, which also looks a little odd.
https://github.com/llvm/llvm-project/pull/110107
More information about the llvm-commits
mailing list