[llvm] [LLVM] Add HasFakeUses to MachineFunction (PR #110097)

Stephen Tozer via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 30 06:40:03 PDT 2024


================
@@ -477,7 +477,7 @@ bool MachineScheduler::runOnMachineFunction(MachineFunction &mf) {
 }
 
 bool PostMachineScheduler::runOnMachineFunction(MachineFunction &mf) {
-  if (skipFunction(mf.getFunction()))
+  if (mf.hasFakeUses() || skipFunction(mf.getFunction()))
----------------
SLTozer wrote:

That seems like a good reason to keep it. The disabling of post RA scheduling for -fextend-lifetimes is a fairly old feature for our downstream branch, and since then enough has changed (particularly the instruction-referencing LiveDebugValues implementation) that post-RA scheduling no longer appears to cause as many problems as before. I'll investigate to see whether enabling post-RA scheduling with -fextend-lifetimes downstream causes any major debug info regressions, which would necessitate modifying post-RA-sched to respect fake uses in some way, but I suspect that this is no longer needed.

https://github.com/llvm/llvm-project/pull/110097


More information about the llvm-commits mailing list