[llvm] [SandboxIR][NFC] Move Instruction classes into a separate file (PR #110294)

LLVM Continuous Integration via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 28 00:30:27 PDT 2024


llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-x64-windows-msvc` running on `windows-gcebot2` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/63/builds/1793

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/clang-windows.py ...' (failure)
...
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\lib\Transforms\Vectorize\SandboxVectorizer\Passes\BottomUpVec.cpp:9:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Transforms/Vectorize/SandboxVectorizer/Passes/BottomUpVec.h:16:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Constant.h:21:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Context.h:14:
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Type.h(61,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
   61 |   friend class TargetExtType;      // For LLVMTy.
      |                ^
      |                ::llvm::
5 warnings generated.
[1215/6068] Building CXX object lib\Transforms\Vectorize\CMakeFiles\LLVMVectorize.dir\SandboxVectorizer\DependencyGraph.cpp.obj
FAILED: lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/SandboxVectorizer/DependencyGraph.cpp.obj 
C:\b\slave\clang-x64-windows-msvc\build\stage1\bin\clang-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\b\slave\clang-x64-windows-msvc\build\stage2\lib\Transforms\Vectorize -IC:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\lib\Transforms\Vectorize -IC:\b\slave\clang-x64-windows-msvc\build\stage2\include -IC:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Zi -gcodeview-ghash /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD  /EHs-c- /GR- -UNDEBUG /showIncludes /Folib\Transforms\Vectorize\CMakeFiles\LLVMVectorize.dir\SandboxVectorizer\DependencyGraph.cpp.obj /Fdlib\Transforms\Vectorize\CMakeFiles\LLVMVectorize.dir\LLVMVectorize.pdb -c -- C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\lib\Transforms\Vectorize\SandboxVectorizer\DependencyGraph.cpp
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\lib\Transforms\Vectorize\SandboxVectorizer\DependencyGraph.cpp:9:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Transforms/Vectorize/SandboxVectorizer/DependencyGraph.h:27:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Instruction.h:15:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/BasicBlock.h:13:
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Value.h(135,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
  135 |   friend class CmpInst;               // For getting `Val`.
      |                ^
      |                ::llvm::
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Value.h(143,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
  143 |   friend class GlobalValue;           // For `Val`.
      |                ^
      |                ::llvm::
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Value.h(145,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
  145 |   friend class GlobalObject;          // For `Val`.
      |                ^
      |                ::llvm::
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Value.h(153,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
  153 |   friend class Module;                // For `Val`.
      |                ^
      |                ::llvm::
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\lib\Transforms\Vectorize\SandboxVectorizer\DependencyGraph.cpp:9:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Transforms/Vectorize/SandboxVectorizer/DependencyGraph.h:27:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Instruction.h:16:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Constant.h:21:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Context.h:14:
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Type.h(61,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
   61 |   friend class TargetExtType;      // For LLVMTy.
      |                ^
      |                ::llvm::
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\lib\Transforms\Vectorize\SandboxVectorizer\DependencyGraph.cpp:9:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Transforms/Vectorize/SandboxVectorizer/DependencyGraph.h:27:
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Instruction.h(369,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
  369 |   friend class UnaryInstruction;
      |                ^
      |                ::llvm::
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Instruction.h(1100,9): error: base class 'SingleLLVMInstructionImpl<llvm::UnaryInstruction>' has private constructor
 1100 |       : SingleLLVMInstructionImpl(ID, Opc, LLVMI, Ctx) {}
Step 11 (stage 2 build) failure: stage 2 build (failure)
...
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\lib\Transforms\Vectorize\SandboxVectorizer\Passes\BottomUpVec.cpp:9:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Transforms/Vectorize/SandboxVectorizer/Passes/BottomUpVec.h:16:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Constant.h:21:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Context.h:14:
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Type.h(61,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
   61 |   friend class TargetExtType;      // For LLVMTy.
      |                ^
      |                ::llvm::
5 warnings generated.
[1215/6068] Building CXX object lib\Transforms\Vectorize\CMakeFiles\LLVMVectorize.dir\SandboxVectorizer\DependencyGraph.cpp.obj
FAILED: lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/SandboxVectorizer/DependencyGraph.cpp.obj 
C:\b\slave\clang-x64-windows-msvc\build\stage1\bin\clang-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\b\slave\clang-x64-windows-msvc\build\stage2\lib\Transforms\Vectorize -IC:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\lib\Transforms\Vectorize -IC:\b\slave\clang-x64-windows-msvc\build\stage2\include -IC:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Zi -gcodeview-ghash /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD  /EHs-c- /GR- -UNDEBUG /showIncludes /Folib\Transforms\Vectorize\CMakeFiles\LLVMVectorize.dir\SandboxVectorizer\DependencyGraph.cpp.obj /Fdlib\Transforms\Vectorize\CMakeFiles\LLVMVectorize.dir\LLVMVectorize.pdb -c -- C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\lib\Transforms\Vectorize\SandboxVectorizer\DependencyGraph.cpp
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\lib\Transforms\Vectorize\SandboxVectorizer\DependencyGraph.cpp:9:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Transforms/Vectorize/SandboxVectorizer/DependencyGraph.h:27:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Instruction.h:15:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/BasicBlock.h:13:
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Value.h(135,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
  135 |   friend class CmpInst;               // For getting `Val`.
      |                ^
      |                ::llvm::
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Value.h(143,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
  143 |   friend class GlobalValue;           // For `Val`.
      |                ^
      |                ::llvm::
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Value.h(145,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
  145 |   friend class GlobalObject;          // For `Val`.
      |                ^
      |                ::llvm::
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Value.h(153,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
  153 |   friend class Module;                // For `Val`.
      |                ^
      |                ::llvm::
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\lib\Transforms\Vectorize\SandboxVectorizer\DependencyGraph.cpp:9:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Transforms/Vectorize/SandboxVectorizer/DependencyGraph.h:27:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Instruction.h:16:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Constant.h:21:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Context.h:14:
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Type.h(61,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
   61 |   friend class TargetExtType;      // For LLVMTy.
      |                ^
      |                ::llvm::
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\lib\Transforms\Vectorize\SandboxVectorizer\DependencyGraph.cpp:9:
In file included from C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/Transforms/Vectorize/SandboxVectorizer/DependencyGraph.h:27:
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Instruction.h(369,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
  369 |   friend class UnaryInstruction;
      |                ^
      |                ::llvm::
C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\include\llvm/SandboxIR/Instruction.h(1100,9): error: base class 'SingleLLVMInstructionImpl<llvm::UnaryInstruction>' has private constructor
 1100 |       : SingleLLVMInstructionImpl(ID, Opc, LLVMI, Ctx) {}

```

</details>

https://github.com/llvm/llvm-project/pull/110294


More information about the llvm-commits mailing list