[compiler-rt] [llvm] [Transforms][IPO] Add func suffix in ArgumentPromotion and DeadArgumentElimination (PR #109899)

via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 27 08:45:41 PDT 2024


yonghong-song wrote:

> This is going to cause SamplePGO tooling (both in the compiler and out of it) to need updating. Here's a place in the compiler that needs updating, e.g.:
> 
> https://github.com/llvm/llvm-project/blob/808c498f52c8ff7724f762dab351600864023098/llvm/include/llvm/ProfileData/SampleProf.h#L1107
> 
> To avoid affecting profile handling, and avoid a lot of test churn, can you put this under an option (ideally defaulted off)?

Thanks for the pointer. I will take a look. IIUC, besides '.llvm.' suffix, llvm has some other suffixes as well, e.g., '.<n>' for FULL LTO, '.specailized' (in Transforms/IPO/FunctionSpecialization.cpp). Are they handled properly?

https://github.com/llvm/llvm-project/pull/109899


More information about the llvm-commits mailing list