[llvm] [MIR] Serialize virtual register flags (PR #110228)

via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 27 02:49:16 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 61c8b7159a740d43a6a0fa52756eb479e1a9c1c3 f494d562fb0dbc80ae21dbf2ab10f12e9712c9b5 --extensions h,cpp -- llvm/include/llvm/CodeGen/MIRParser/MIParser.h llvm/include/llvm/CodeGen/MIRYamlMapping.h llvm/include/llvm/CodeGen/TargetRegisterInfo.h llvm/lib/CodeGen/MIRParser/MIParser.cpp llvm/lib/CodeGen/MIRParser/MIRParser.cpp llvm/lib/CodeGen/MIRPrinter.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/CodeGen/MIRParser/MIParser.h b/llvm/include/llvm/CodeGen/MIRParser/MIParser.h
index a1a48f2fb0..531eb04a24 100644
--- a/llvm/include/llvm/CodeGen/MIRParser/MIParser.h
+++ b/llvm/include/llvm/CodeGen/MIRParser/MIParser.h
@@ -151,7 +151,7 @@ public:
   /// Return null if the name isn't a register bank.
   const RegisterBank *getRegBank(StringRef Name);
 
-  bool getVRegFlagValue(StringRef FlagName, uint8_t& FlagValue) const;
+  bool getVRegFlagValue(StringRef FlagName, uint8_t &FlagValue) const;
 
   PerTargetMIParsingState(const TargetSubtargetInfo &STI)
     : Subtarget(STI) {
diff --git a/llvm/lib/CodeGen/MIRParser/MIParser.cpp b/llvm/lib/CodeGen/MIRParser/MIParser.cpp
index fb33384477..fecd921b6a 100644
--- a/llvm/lib/CodeGen/MIRParser/MIParser.cpp
+++ b/llvm/lib/CodeGen/MIRParser/MIParser.cpp
@@ -127,11 +127,12 @@ bool PerTargetMIParsingState::getRegisterByName(StringRef RegName,
   return false;
 }
 
-bool PerTargetMIParsingState::getVRegFlagValue(StringRef FlagName, uint8_t& FlagValue) const {
+bool PerTargetMIParsingState::getVRegFlagValue(StringRef FlagName,
+                                               uint8_t &FlagValue) const {
   const auto *TRI = Subtarget.getRegisterInfo();
   assert(TRI && "Expected target register info");
   auto [HasVReg, FV] = TRI->getVRegFlagValue(FlagName);
-  if(!HasVReg)
+  if (!HasVReg)
     return true;
   FlagValue = FV;
   return false;
diff --git a/llvm/lib/CodeGen/MIRParser/MIRParser.cpp b/llvm/lib/CodeGen/MIRParser/MIRParser.cpp
index 452f6418a6..399922a90f 100644
--- a/llvm/lib/CodeGen/MIRParser/MIRParser.cpp
+++ b/llvm/lib/CodeGen/MIRParser/MIRParser.cpp
@@ -684,13 +684,13 @@ bool MIRParserImpl::parseRegisterInfo(PerFunctionMIParsingState &PFS,
         return error(Error, VReg.PreferredRegister.SourceRange);
     }
 
-    for(const auto &FlagStringValue: VReg.RegisterFlags) {
+    for (const auto &FlagStringValue : VReg.RegisterFlags) {
       uint8_t FlagValue;
-      if(Target->getVRegFlagValue(FlagStringValue.Value, FlagValue))
+      if (Target->getVRegFlagValue(FlagStringValue.Value, FlagValue))
         return error(FlagStringValue.SourceRange.Start,
-                      Twine("use of undefined register flag '") +
-                          FlagStringValue.Value + "'");
-        Info.Flags.push_back(FlagValue);
+                     Twine("use of undefined register flag '") +
+                         FlagStringValue.Value + "'");
+      Info.Flags.push_back(FlagValue);
     }
   }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/110228


More information about the llvm-commits mailing list