[llvm] [llvm][SPIRV] Expose fast `popcnt` support for SPIR-V targets (PR #109845)

Vyacheslav Levytskyy via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 27 00:04:53 PDT 2024


================
@@ -0,0 +1,114 @@
+; RUN: opt -O3 -mtriple=spirv32-- %s -o - | llc -O3 -mtriple=spirv32-- -o - | FileCheck %s
+; RUN: %if spirv-tools %{ opt -O3 -mtriple=spirv32-- %s -o - | llc -O3 -mtriple=spirv32-- -o - -filetype=obj | spirv-val %}
----------------
VyacheslavLevytskyy wrote:

> that insertion is incorrect

yes, this has already been addressed in https://github.com/llvm/llvm-project/pull/109660 (https://github.com/llvm/llvm-project/blob/01c777628e17fce039f1b50297e6c2125445a255/llvm/lib/Target/SPIRV/SPIRVPreLegalizer.cpp#L344-L366)

> vreg lifetimes get messed up and verification still fails

I didn't see the case to be sure, but I'd guess that it's the same problem as we're discussing currently within https://github.com/llvm/llvm-project/pull/110019

https://github.com/llvm/llvm-project/pull/109845


More information about the llvm-commits mailing list