[llvm] [Object] Avoid repeated map lookups (NFC) (PR #110201)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 26 19:55:22 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-binary-utilities
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/110201.diff
1 Files Affected:
- (modified) llvm/lib/Object/ArchiveWriter.cpp (+1-2)
``````````diff
diff --git a/llvm/lib/Object/ArchiveWriter.cpp b/llvm/lib/Object/ArchiveWriter.cpp
index 114045561366d7..c61ba868efe60e 100644
--- a/llvm/lib/Object/ArchiveWriter.cpp
+++ b/llvm/lib/Object/ArchiveWriter.cpp
@@ -754,9 +754,8 @@ static Expected<std::vector<unsigned>> getSymbols(SymbolicFile *Obj,
raw_string_ostream NameStream(Name);
if (Error E = S.printName(NameStream))
return std::move(E);
- if (Map->find(Name) != Map->end())
+ if (!Map->try_emplace(Name, Index).second)
continue; // ignore duplicated symbol
- (*Map)[Name] = Index;
if (Map == &SymMap->Map) {
Ret.push_back(SymNames.tell());
SymNames << Name << '\0';
``````````
</details>
https://github.com/llvm/llvm-project/pull/110201
More information about the llvm-commits
mailing list