[llvm] [WebAssembly] Unify type checking in AsmTypeCheck (PR #110094)

Heejin Ahn via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 14:22:55 PDT 2024


================
@@ -246,23 +295,16 @@ bool WebAssemblyAsmTypeCheck::getSignature(SMLoc ErrorLoc,
       TypeName = "tag";
       break;
     default:
-      return true;
+      assert(false);
----------------
aheejin wrote:

Yeah that sounds better. (I changed this from `return true` to this because if we are here this is not the type checking error but the program error)

https://github.com/llvm/llvm-project/pull/110094


More information about the llvm-commits mailing list