[llvm] Reapply "[MemProf] Streamline and avoid unnecessary context id duplication (#107918)" (PR #110036)
Teresa Johnson via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 26 09:49:58 PDT 2024
================
@@ -1377,9 +1377,16 @@ void CallsiteContextGraph<DerivedCCG, FuncTy, CallTy>::
// Compute the last node's context ids once, as it is shared by all calls in
// this entry.
DenseSet<uint32_t> LastNodeContextIds = LastNode->getContextIds();
- assert(!LastNodeContextIds.empty());
----------------
teresajohnson wrote:
I had rebased my client right before mailing this PR and a retest showed this new code from #109857 asserted with the test case from this PR. The assert is too strict at this point because we may have already reassigned the context ids on this last node to a different stack node (the same reason why we need to recompute the stack nodes for each call below).
https://github.com/llvm/llvm-project/pull/110036
More information about the llvm-commits
mailing list