[llvm] [RISCV] Enable load clustering by default (PR #73789)

Alex Bradbury via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 07:23:35 PDT 2024


asb wrote:

> > I've rebased and repushed (again actually, I had done it before but forgotten to push). I've adopted Philip's suggestion of just flipping the default for the option for this patch.
> 
> Thanks! It seems there are new conflicts (we are actively changing). I found some regressions, but I don't mean to block this patch.

Easy enough for me to regenerate and fix the conflicts if we're happy to merge. As you point out, there are some minor regressions in a few tests but I think what I need from reviewers is an indication that they agree this is the right direction, and if we find any regressions that are meaningful in practice we can follow up with fixes in tree. I can do my own testing, but given your ping that you would like to see this enabled, I'm guessing you've observed it's at least no worse than the status quo on benchmarks, which would be supportive of moving ahead?

https://github.com/llvm/llvm-project/pull/73789


More information about the llvm-commits mailing list