[compiler-rt] Test fixups for MSVC. (PR #109887)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 03:31:36 PDT 2024


================
@@ -1,15 +0,0 @@
-// RUN: %clangxx_asan -O0 %s -o %t && not %run %t 2>&1 | FileCheck %s
-// FIXME: merge this with the common null_deref test when we can run common
-// tests on Windows.
-
-__attribute__((noinline))
-static void NullDeref(int *ptr) {
-  // CHECK: ERROR: AddressSanitizer: access-violation on unknown address
-  // CHECK:   {{0x0*000.. .*pc 0x.*}}
-  ptr[10]++;  // BOOM
-}
-int main() {
-  NullDeref((int*)0);
----------------
mstorsjo wrote:

Right - but I don't see any `XFAIL` being removed from `TestCases/null_deref.cpp`, so to me it seems like that test was already being executed on Windows, with clang - this change just makes it work with MSVC too?

(I.e. in other word, this FIXME that you're removing was already ripe to be removed before this patch.)

https://github.com/llvm/llvm-project/pull/109887


More information about the llvm-commits mailing list