[llvm] [BOLT] Ignore AArch64 markers outside their sections. (PR #74106)

via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 01:08:17 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 84b1489c8f8d4fb3c541167301c29ee4dad1af78 0191077738b6bdd3e23bf7214e0ae028fb784a8f --extensions h,cpp -- bolt/lib/Rewrite/RewriteInstance.cpp llvm/include/llvm/Object/ObjectFile.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/bolt/lib/Rewrite/RewriteInstance.cpp b/bolt/lib/Rewrite/RewriteInstance.cpp
index a5ad24fc92..b6d94b9868 100644
--- a/bolt/lib/Rewrite/RewriteInstance.cpp
+++ b/bolt/lib/Rewrite/RewriteInstance.cpp
@@ -812,17 +812,14 @@ void RewriteInstance::discoverFileObjects() {
     auto SymType = cantFail(S.Symbol.getType());
     // Skip warnings for common benign cases.
     if (opts::Verbosity < 1 && SymType == SymbolRef::ST_Other)
-      return false;  // E.g. ELF::STT_TLS.
+      return false; // E.g. ELF::STT_TLS.
 
     auto SymName = S.Symbol.getName();
     auto SecName = cantFail(S.Symbol.getSection())->getName();
     BC->errs() << "BOLT-WARNING: ignoring symbol "
-      << (SymName ? *SymName : "[unnamed]")
-      << " at 0x"
-      << Twine::utohexstr(S.Address)
-      << ", which lies outside "
-      << (SecName ? *SecName : "[unnamed]")
-      << "\n";
+               << (SymName ? *SymName : "[unnamed]") << " at 0x"
+               << Twine::utohexstr(S.Address) << ", which lies outside "
+               << (SecName ? *SecName : "[unnamed]") << "\n";
 
     return false;
   };

``````````

</details>


https://github.com/llvm/llvm-project/pull/74106


More information about the llvm-commits mailing list