[llvm] [mlir] [NFC] Add explicit #include abi-breaking.h where its macros are used. (PR #109453)

Daniil Fukalov via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 15:03:15 PDT 2024


dfukalov wrote:

> None of the MLIR changes are needed, we are covered by -Wundef I believe.
> 
There are some places in MLIR where the option will not work, e.g.
https://github.com/llvm/llvm-project/blob/fe06a6daae6be85d47cd1e51654e91f9ac6e63d7/mlir/include/mlir/Dialect/Transform/Interfaces/TransformInterfaces.h#L199
, since `-Wundef` works for `#if` only, not for `#ifdef`.

We have no coding style requirement of the topic **and** pre-commit tests/checks. While we have no such requirements, the macros which configure compilation still be fragile.


https://github.com/llvm/llvm-project/pull/109453


More information about the llvm-commits mailing list