[clang] [llvm] Deprecate the `-fbasic-block-sections=labels` option. (PR #107494)

[via llvm-commits]

zeroomega wrote:

Hi

This change likely broke the clang build:

```
[4323/4602](116) Building CXX object tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o
 FAILED: tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o 
 /b/s/w/ir/x/w/rc/cxx-rbeirddhris/reclient-cxx-wrapper.sh /b/s/w/ir/x/w/cipd/bin/clang++ --sysroot=/b/s/w/ir/x/w/cipd/linux -DGTEST_HAS_RTTI=0 -DLLD_VENDOR=\"Fuchsia\" -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/s/w/ir/x/w/llvm_build/tools/lld/ELF -I/b/s/w/ir/x/w/llvm-llvm-project/lld/ELF -I/b/s/w/ir/x/w/llvm-llvm-project/lld/include -I/b/s/w/ir/x/w/llvm_build/tools/lld/include -I/b/s/w/ir/x/w/rc/tensorflow-venv/store/python_venv-nacb1phkpgklqiq46g3ivnt518/contents/lib/python3.8/site-packages/tensorflow/include -I/b/s/w/ir/x/w/llvm_build/include -I/b/s/w/ir/x/w/llvm-llvm-project/llvm/include -isystem /b/s/w/ir/x/w/install-zlib-x86_64-linux-gnu/include -isystem /b/s/w/ir/x/w/install-zstd-x86_64-linux-gnu/include -stdlib=libc++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -ffat-lto-objects -ffile-prefix-map=/b/s/w/ir/x/w/llvm_build=../llvm-llvm-project -ffile-prefix-map=/b/s/w/ir/x/w/llvm-llvm-project/= -no-canonical-prefixes -O3 -DNDEBUG -std=c++17 -fvisibility=default  -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -MD -MT tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o -MF tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o.d -o tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o -c /b/s/w/ir/x/w/llvm-llvm-project/lld/ELF/LTO.cpp
 /b/s/w/ir/x/w/llvm-llvm-project/lld/ELF/LTO.cpp:74:49: error: no member named 'Labels' in 'llvm::BasicBlockSection'
    74 |       c.Options.BBSections = BasicBlockSection::Labels;
       |                              ~~~~~~~~~~~~~~~~~~~^
 1 error generated.
```

See build task: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-base-linux-x64/b8735797591984119265/overview

Could you revert your change please?

https://github.com/llvm/llvm-project/pull/107494