[llvm] [NFC] Switch a number of DenseMaps to SmallDenseMaps for speedup (PR #109417)

Wed Sep 25 08:31:03 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lld-x86_64-ubuntu-fast` running on `as-builder-4` while building `llvm` at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/33/builds/3713

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
...
2.605 [2/41/672] Linking CXX executable unittests/ObjectYAML/ObjectYAMLTests
2.915 [2/40/673] Linking CXX executable unittests/Support/SupportTests
2.938 [2/39/674] Linking CXX executable unittests/Object/ObjectTests
2.983 [2/38/675] Linking CXX executable unittests/Bitcode/BitcodeTests
3.103 [2/37/676] Linking CXX executable unittests/FuzzMutate/FuzzMutateTests
3.332 [2/36/677] Linking CXX executable unittests/Transforms/Vectorize/VectorizeTests
3.532 [2/35/678] Linking CXX executable unittests/MC/MCTests
3.606 [2/34/679] Linking CXX executable unittests/Transforms/IPO/IPOTests
3.695 [2/33/680] Linking CXX executable unittests/DebugInfo/LogicalView/DebugInfoLogicalViewTests
4.325 [2/32/681] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/SparsePropagation.cpp.o
FAILED: unittests/Analysis/CMakeFiles/AnalysisTests.dir/SparsePropagation.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/build/unittests/Analysis -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/unittests/Analysis -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/build/include -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/include -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/third-party/unittest/googletest/include -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wno-variadic-macros -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -std=c++17 -MD -MT unittests/Analysis/CMakeFiles/AnalysisTests.dir/SparsePropagation.cpp.o -MF unittests/Analysis/CMakeFiles/AnalysisTests.dir/SparsePropagation.cpp.o.d -o unittests/Analysis/CMakeFiles/AnalysisTests.dir/SparsePropagation.cpp.o -c /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/unittests/Analysis/SparsePropagation.cpp
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/unittests/Analysis/SparsePropagation.cpp:141:8: error: ‘void {anonymous}::TestLatticeFunc::ComputeInstructionState(llvm::Instruction&, llvm::DenseMap<llvm::PointerIntPair<llvm::Value*, 2, {anonymous}::IPOGrouping>, {anonymous}::TestLatticeVal>&, llvm::SparseSolver<llvm::PointerIntPair<llvm::Value*, 2, {anonymous}::IPOGrouping>, {anonymous}::TestLatticeVal, llvm::LatticeKeyInfo<llvm::PointerIntPair<llvm::Value*, 2, {anonymous}::IPOGrouping> > >&)’ marked ‘override’, but does not override
  141 |   void ComputeInstructionState(
      |        ^~~~~~~~~~~~~~~~~~~~~~~
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/unittests/Analysis/SparsePropagation.cpp:230:19: error: cannot declare field ‘{anonymous}::SparsePropagationTest::Lattice’ to be of abstract type ‘{anonymous}::TestLatticeFunc’
  230 |   TestLatticeFunc Lattice;
      |                   ^~~~~~~
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/unittests/Analysis/SparsePropagation.cpp:98:7: note:   because the following virtual functions are pure within ‘{anonymous}::TestLatticeFunc’:
   98 | class TestLatticeFunc
      |       ^~~~~~~~~~~~~~~
In file included from /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/unittests/Analysis/SparsePropagation.cpp:9:
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/include/llvm/Analysis/SparsePropagation.h:90:16: note:     ‘void llvm::AbstractLatticeFunction<LatticeKey, LatticeVal>::ComputeInstructionState(llvm::Instruction&, llvm::SmallDenseMap<LatticeKey, LatticeVal, 16>&, llvm::SparseSolver<LatticeKey, LatticeVal>&) [with LatticeKey = llvm::PointerIntPair<llvm::Value*, 2, {anonymous}::IPOGrouping>; LatticeVal = {anonymous}::TestLatticeVal]’
   90 |   virtual void ComputeInstructionState(
      |                ^~~~~~~~~~~~~~~~~~~~~~~
4.952 [2/31/682] Linking CXX executable unittests/tools/llvm-cfi-verify/CFIVerifyTests
5.168 [2/30/683] Linking CXX executable unittests/Target/PowerPC/PowerPCTests
5.284 [2/29/684] Linking CXX executable unittests/Target/LoongArch/LoongArchTests
5.377 [2/28/685] Linking CXX executable unittests/Target/VE/VETests
5.507 [2/27/686] Linking CXX executable unittests/Target/WebAssembly/WebAssemblyTests
5.509 [2/26/687] Linking CXX executable unittests/Target/ARM/ARMTests
5.702 [2/25/688] Linking CXX executable unittests/Target/AArch64/AArch64Tests
5.850 [2/24/689] Linking CXX executable unittests/Target/RISCV/RISCVTests
5.925 [2/23/690] Linking CXX executable unittests/Transforms/Instrumentation/InstrumentationTests
6.087 [2/22/691] Linking CXX executable unittests/Frontend/LLVMFrontendTests
6.118 [2/21/692] Linking CXX executable unittests/Transforms/Coroutines/CoroTests
6.364 [2/20/693] Linking CXX executable unittests/tools/llvm-mca/LLVMMCATests
6.405 [2/19/694] Linking CXX executable unittests/Transforms/Utils/UtilsTests
6.635 [2/18/695] Linking CXX executable unittests/Passes/PassBuilderBindings/PassesBindingsTests
6.912 [2/17/696] Linking CXX executable unittests/Passes/Plugins/PluginsTests
7.091 [2/16/697] Linking CXX executable unittests/IR/IRTests
7.115 [2/15/698] Linking CXX executable unittests/Transforms/Scalar/ScalarTests
7.194 [2/14/699] Linking CXX executable unittests/ExecutionEngine/Orc/OrcJITTests
7.424 [2/13/700] Linking CXX executable unittests/Target/X86/X86Tests
7.624 [2/12/701] Linking CXX executable unittests/MC/AMDGPU/AMDGPUMCTests
7.702 [2/11/702] Linking CXX executable unittests/tools/llvm-exegesis/LLVMExegesisTests
7.821 [2/10/703] Linking CXX executable unittests/Target/AMDGPU/AMDGPUTests
8.119 [2/9/704] Linking CXX executable unittests/ExecutionEngine/MCJIT/MCJITTests
10.614 [2/8/705] Linking CXX executable unittests/Target/TargetMachineCTests

```

</details>

https://github.com/llvm/llvm-project/pull/109417