[llvm] [NFC] Switch a number of DenseMaps to SmallDenseMaps for speedup (PR #109417)

Wed Sep 25 06:29:48 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-win-fast` running on `as-builder-3` while building `llvm` at step 7 "test-build-unified-tree-check-llvm-unit".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/2/builds/7575

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 7 (test-build-unified-tree-check-llvm-unit) failure: test (failure)
...
[507/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\IndexedAccessorTest.cpp.obj
[508/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\DataExtractorTest.cpp.obj
[509/707] Linking CXX executable unittests\CodeGen\GlobalISel\GlobalISelTests.exe
[510/707] Linking CXX executable unittests\Remarks\RemarksTests.exe
[511/707] Linking CXX executable unittests\MC\MCTests.exe
[512/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\MD5Test.cpp.obj
[513/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\MathExtrasTest.cpp.obj
[514/707] Building CXX object unittests\Target\ARM\CMakeFiles\ARMTests.dir\InstSizes.cpp.obj
[515/707] Building CXX object unittests\Target\ARM\CMakeFiles\ARMTests.dir\MachineInstrTest.cpp.obj
[516/707] Building CXX object unittests\Analysis\CMakeFiles\AnalysisTests.dir\SparsePropagation.cpp.obj
FAILED: unittests/Analysis/CMakeFiles/AnalysisTests.dir/SparsePropagation.cpp.obj 
C:\ninja\ccache.exe C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\unittests\Analysis -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\Analysis -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\include -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\third-party\unittest\googletest\include -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\third-party\unittest\googlemock\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -wd4251 -wd4275 -w14062 -we4238 /Gw /O2 /Ob2 /DNDEBUG -MD  /EHs-c- /GR- -std:c++17 /showIncludes /Founittests\Analysis\CMakeFiles\AnalysisTests.dir\SparsePropagation.cpp.obj /Fdunittests\Analysis\CMakeFiles\AnalysisTests.dir\ /FS -c C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\Analysis\SparsePropagation.cpp
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\Analysis\SparsePropagation.cpp(141): error C3668: '`anonymous-namespace'::TestLatticeFunc::ComputeInstructionState': method with override specifier 'override' did not override any base class methods
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\Analysis\SparsePropagation.cpp(230): error C2259: '`anonymous-namespace'::TestLatticeFunc': cannot instantiate abstract class
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\Analysis\SparsePropagation.cpp(98): note: see declaration of '`anonymous-namespace'::TestLatticeFunc'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\Analysis\SparsePropagation.cpp(230): note: due to following members:
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\Analysis\SparsePropagation.cpp(230): note: 'void llvm::AbstractLatticeFunction<`anonymous-namespace'::TestLatticeKey,`anonymous-namespace'::TestLatticeVal>::ComputeInstructionState(llvm::Instruction &,llvm::SmallDenseMap<LatticeKey,LatticeVal,16,llvm::DenseMapInfo<KeyT,void>,llvm::detail::DenseMapPair<KeyT,ValueT>> &,llvm::SparseSolver<LatticeKey,LatticeVal,llvm::LatticeKeyInfo<`anonymous-namespace'::TestLatticeKey>> &)': is abstract
        with
        [
            LatticeKey=`anonymous-namespace'::TestLatticeKey,
            LatticeVal=`anonymous-namespace'::TestLatticeVal,
            KeyT=`anonymous-namespace'::TestLatticeKey,
            ValueT=`anonymous-namespace'::TestLatticeVal
        ]
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include\llvm/Analysis/SparsePropagation.h(90): note: see declaration of 'llvm::AbstractLatticeFunction<`anonymous-namespace'::TestLatticeKey,`anonymous-namespace'::TestLatticeVal>::ComputeInstructionState'
[517/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\ManagedStatic.cpp.obj
[518/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\SipHashTest.cpp.obj
[519/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\ModRefTest.cpp.obj
[520/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\SuffixTreeTest.cpp.obj
[521/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\TypeNameTest.cpp.obj
[522/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\RegexTest.cpp.obj
[523/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\SHA256.cpp.obj
[524/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\TypeTraitsTest.cpp.obj
[525/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\TypeSizeTest.cpp.obj
[526/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\MemoryTest.cpp.obj
[527/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\SignalsTest.cpp.obj
[528/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\OptimizedStructLayoutTest.cpp.obj
[529/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\SourceMgrTest.cpp.obj
[530/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\ReverseIterationTest.cpp.obj
[531/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\Threading.cpp.obj
[532/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\UTCTimeTest.cpp.obj
[533/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\UnicodeTest.cpp.obj
[534/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\ScaledNumberTest.cpp.obj
[535/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\ParallelTest.cpp.obj
[536/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\ProgramTest.cpp.obj
[537/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\ProcessTest.cpp.obj
[538/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\TimerTest.cpp.obj
[539/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\VersionTupleTest.cpp.obj
[540/707] Building CXX object unittests\Support\CMakeFiles\SupportTests.dir\TrailingObjectsTest.cpp.obj

```

</details>

https://github.com/llvm/llvm-project/pull/109417