[llvm] [ctx_prof] Simple ICP criteria during module inliner (PR #109881)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 20:59:54 PDT 2024


================
@@ -242,13 +260,22 @@ PreservedAnalyses ModuleInlinerPass::run(Module &M,
           // iteration because the next iteration may not happen and we may
----------------
kazutakahirata wrote:

Without your patch, if `ICB->getCalledFunction() != nullptr`, then you would do:

```
        if (NewCallee)
          if (!NewCallee->isDeclaration())
            Calls->push({ICB, NewHistoryID});
```

With your patch but without the contexual profile, that behavior seems to be lost.  Is that intended?


https://github.com/llvm/llvm-project/pull/109881


More information about the llvm-commits mailing list