[llvm] 4c3fccd - [llvm-ifs] Avoid repeated map lookups (NFC) (#109750)

via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 16:40:57 PDT 2024


Author: Kazu Hirata
Date: 2024-09-24T16:40:54-07:00
New Revision: 4c3fccdd8831c8ef8c7191a7f68e8341c3123eb7

URL: https://github.com/llvm/llvm-project/commit/4c3fccdd8831c8ef8c7191a7f68e8341c3123eb7
DIFF: https://github.com/llvm/llvm-project/commit/4c3fccdd8831c8ef8c7191a7f68e8341c3123eb7.diff

LOG: [llvm-ifs] Avoid repeated map lookups (NFC) (#109750)

Added: 
    

Modified: 
    llvm/tools/llvm-ifs/llvm-ifs.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-ifs/llvm-ifs.cpp b/llvm/tools/llvm-ifs/llvm-ifs.cpp
index 169f601d459e36..b76ea8dec0c98c 100644
--- a/llvm/tools/llvm-ifs/llvm-ifs.cpp
+++ b/llvm/tools/llvm-ifs/llvm-ifs.cpp
@@ -441,12 +441,9 @@ int llvm_ifs_main(int argc, char **argv, const llvm::ToolContext &) {
     }
 
     for (auto Symbol : TargetStub->Symbols) {
-      auto SI = SymbolMap.find(Symbol.Name);
-      if (SI == SymbolMap.end()) {
-        SymbolMap.insert(
-            std::pair<std::string, IFSSymbol>(Symbol.Name, Symbol));
+      auto [SI, Inserted] = SymbolMap.try_emplace(Symbol.Name, Symbol);
+      if (Inserted)
         continue;
-      }
 
       assert(Symbol.Name == SI->second.Name && "Symbol Names Must Match.");
 


        


More information about the llvm-commits mailing list