[llvm] [llvm][NFC] Remove redundant copy parameter (PR #109859)

Amr Hesham via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 13:30:40 PDT 2024


https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/109859

Remove redundant copy parameter and move it

from `explicit OwningMemoryBlock(MemoryBlock M) : M(M) {}`

to `explicit OwningMemoryBlock(MemoryBlock M) : M(std::move(m)) {}`

Fixes: #95640

>From 19fe5c18217b5eaa0ae80aba4d5118b2ac364d23 Mon Sep 17 00:00:00 2001
From: AmrDeveloper <amr96 at programmer.net>
Date: Tue, 24 Sep 2024 22:28:56 +0200
Subject: [PATCH] [llvm][NFC] Remove redundant copy parameter

---
 llvm/include/llvm/Support/Memory.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/include/llvm/Support/Memory.h b/llvm/include/llvm/Support/Memory.h
index d7d60371d315f0..c02a3cc14dc7de 100644
--- a/llvm/include/llvm/Support/Memory.h
+++ b/llvm/include/llvm/Support/Memory.h
@@ -137,7 +137,7 @@ namespace sys {
   class OwningMemoryBlock {
   public:
     OwningMemoryBlock() = default;
-    explicit OwningMemoryBlock(MemoryBlock M) : M(M) {}
+    explicit OwningMemoryBlock(MemoryBlock M) : M(std::move(M)) {}
     OwningMemoryBlock(OwningMemoryBlock &&Other) {
       M = Other.M;
       Other.M = MemoryBlock();



More information about the llvm-commits mailing list