[llvm] [SDAG] Honor signed arguments in floating point libcalls (PR #109134)

Timothy Pearson via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 10:22:31 PDT 2024


================
@@ -2205,7 +2205,13 @@ void SelectionDAGLegalize::ExpandFPLibCall(SDNode* Node,
     Results.push_back(Tmp.first);
     Results.push_back(Tmp.second);
   } else {
-    SDValue Tmp = ExpandLibCall(LC, Node, false).first;
+    bool IsSignedArgument = false;
+    switch (Node->getOpcode()) {
+    case ISD::FLDEXP:
+      IsSignedArgument = true;
+      break;
+    }
----------------
tpearson-ssc wrote:

I used the original structure to make it more obvious that there might be other (future) instructions that also need signed arguments.  That said, if this is the only barrier to merge I'll accept the change.

Is there a timeline on when this PR might be merged?  I'm coordinating with other Debian maintainers at the moment, as we need to not only stable-update Clang but also rebuild affected packages.

Thanks!

https://github.com/llvm/llvm-project/pull/109134


More information about the llvm-commits mailing list