[llvm] [NVPTX] Fix NVPTXLowerUnreachable::isLoweredToTrap logic (PR #109730)

[Justin Fargnoli via llvm-commits]

================
@@ -110,17 +110,25 @@ StringRef NVPTXLowerUnreachable::getPassName() const {
 }
 
 // =============================================================================
-// Returns whether a `trap` intrinsic should be emitted before I.
+// Returns whether a `trap` intrinsic would be emitted before I.
 //
 // This is a copy of the logic in SelectionDAGBuilder::visitUnreachable().
 // =============================================================================
 bool NVPTXLowerUnreachable::isLoweredToTrap(const UnreachableInst &I) const {
-  if (!TrapUnreachable)
-    return false;
-  if (!NoTrapAfterNoreturn)
-    return true;
----------------
justinfargnoli wrote:

> this pass would not generate traps if NoTrapAfterNoreturn was set

It seems like a trap would be generated if `NoTrapAfterNoreturn` is set and `Call->doesNotReturn()` is true. Am I missing something? 

https://github.com/llvm/llvm-project/pull/109730