[llvm] [NFC][LoopVectorize] Cache result of requiresScalarEpilogue (PR #108981)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 00:01:25 PDT 2024


https://github.com/fhahn commented:

> > Would it be simpler to have a separate helper `setRequiresScalarEpilogue` that's called once up-front with `requiresScalarEpilogue` simply returning the decision as done in multiple other places?
> 
> OK, I've tried doing this, but I realised there are places where we have to invalidate the decision due to changes in the scalar epilogue status or interleave groups. However, that also means my first version was also incorrect even though all tests passed!


Thanks for checking, does this mean we are missing a new test to cover this case?

https://github.com/llvm/llvm-project/pull/108981


More information about the llvm-commits mailing list