[llvm] LLVMContext API to print single SyncScope ID (PR #109484)
Artem Belevich via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 23 15:42:11 PDT 2024
https://github.com/Artem-B commented:
The commit could use a better title. The point is that we're introducing a new API, so something along the lines of `LLVMContext: add getSyncScopeName() to lookup individual scope name` would work better than the one that mentions printing.
The changes that take advantage of the new API I would put into a separate patch.
The change in SIISelLowering.cpp could be considered to be a straightforward example of the new API use, and can probably go along with the API change.
However the change to NVPTX adds the new functionality and should probably be split into a separate patch.
The changes themselves look good, so it's just a mechanical exercise to land the changes as the minimal self-contained patches.
https://github.com/llvm/llvm-project/pull/109484
More information about the llvm-commits
mailing list