[lld] [llvm] [llvm-objdump] Print ... even if a data mapping symbol is active (PR #109553)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 23 13:40:50 PDT 2024


MaskRay wrote:

> LGTM for the change. From the build kite result looks like MC/ARM/ltorg-range.s will need to add `-z`.
> 
> arm-none-eabi-objdump and aarch64-none-elf-objdump use ellipsis for more than 4-bytes of zeroes.
> 
> I tend to use GNU objdump whenever I have a file with a non-trivial amount of zeroes so for me this is a big useability improvement.
> 
> May want to give jh7370 some time to review too.

Thanks for the review. I hope this is useful to your lld patch for testing. 

I recall that jh7370 mentioned vacation plan recently. Anyhow I'll hold off merging this for two days.


https://github.com/llvm/llvm-project/pull/109553


More information about the llvm-commits mailing list