[llvm] [WebAssembly] Allow AsmTypeCheck detect multiple errors in function (PR #109705)

Heejin Ahn via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 23 12:57:11 PDT 2024


================
@@ -70,14 +70,9 @@ void WebAssemblyAsmTypeCheck::dumpTypeStack(Twine Msg) {
 }
 
 bool WebAssemblyAsmTypeCheck::typeError(SMLoc ErrorLoc, const Twine &Msg) {
-  // Once you get one type error in a function, it will likely trigger more
-  // which are mostly not helpful.
-  if (TypeErrorThisFunction)
----------------
aheejin wrote:

We can probably make it a follow-up or an improvement, but I feel that's more confusing, given that no other tools work that way. As I summarized in https://github.com/llvm/llvm-project/pull/109705#issuecomment-2369243689,
- Binaryen parser: Bail out at first error
- Binaryen validator: Report all errors
- Wabt parser: Report all errors
So no other tools do "report future errors but only one error per block" thing.

https://github.com/llvm/llvm-project/pull/109705


More information about the llvm-commits mailing list