[llvm] [WebAssembly] Allow AsmTypeCheck detect multiple errors in function (PR #109705)

Sam Clegg via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 23 12:27:03 PDT 2024


================
@@ -70,14 +70,9 @@ void WebAssemblyAsmTypeCheck::dumpTypeStack(Twine Msg) {
 }
 
 bool WebAssemblyAsmTypeCheck::typeError(SMLoc ErrorLoc, const Twine &Msg) {
-  // Once you get one type error in a function, it will likely trigger more
-  // which are mostly not helpful.
-  if (TypeErrorThisFunction)
----------------
sbc100 wrote:

This change looks reasonable to me, but I do wonder if we should maybe do as thomas suggested in the meeting and only report one error per block?   So this would be `TypeErrorThisBlock`?

I don't feel to strongly though.

https://github.com/llvm/llvm-project/pull/109705


More information about the llvm-commits mailing list