[llvm] [DWARF] Generalize DWARFTypePrinter to a template class (PR #109459)
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 23 11:53:00 PDT 2024
dwblaikie wrote:
> Seems reasonable. I guess LLDB's `DWARFDIE` is sufficiently different from LLVM's that there are no plans to consolidate those?
The LLVM one is a decade+ old fork of the LLDB one. It would be nice to unify them at some point - I'm not sure this is that point (but it might be - though it'd be a wider discussion) but at least it's probably a step along that path. (eg: probably moving the LLDB DWARFDIE APIs to use the LLVM naming convention (eg: change the lldb one from GetParent to getParent - or add an overload with the intent that eventually the names would match and the lldb one would be deprecated/removed as part of the transition to use the LLVM API/move the lldb one into LLVM, and the difference between the lldb DWARFDIE having a `children()` accessor, and the LLVM DWARFDie API having begin/end on the DWARFDie directly))
So, if some folks have opinions on if/how much we should try to merge the forks today, motivated in part by this work, I think we should have that discussion.
https://github.com/llvm/llvm-project/pull/109459
More information about the llvm-commits
mailing list