[llvm] [SystemZ] Dump function signature on missing arg extension. (PR #109699)

via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 23 11:10:54 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 85220a0c651e565ab576c5be17c1ec5c9eb2a350 d89caff3f5095631c661698adaec43b95d00a0ee --extensions cpp,h -- llvm/lib/Target/SystemZ/SystemZISelLowering.cpp llvm/lib/Target/SystemZ/SystemZISelLowering.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/SystemZ/SystemZISelLowering.cpp b/llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
index a7fdc3bc40..ea53b7d632 100644
--- a/llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
+++ b/llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
@@ -9848,9 +9848,9 @@ static void printFunctionArgExts(const Function *F, raw_fd_ostream &OS) {
   OS << ")\n";
 }
 
-void SystemZTargetLowering::
-verifyNarrowIntegerArgs_Call(const SmallVectorImpl<ISD::OutputArg> &Outs,
-                             const Function *F, SDValue Callee) const {
+void SystemZTargetLowering::verifyNarrowIntegerArgs_Call(
+    const SmallVectorImpl<ISD::OutputArg> &Outs, const Function *F,
+    SDValue Callee) const {
   bool IsInternal = false;
   const Function *CalleeFn = nullptr;
   if (auto *G = dyn_cast<GlobalAddressSDNode>(Callee))
@@ -9858,7 +9858,8 @@ verifyNarrowIntegerArgs_Call(const SmallVectorImpl<ISD::OutputArg> &Outs,
       IsInternal = isFullyInternal(CalleeFn);
   if (!verifyNarrowIntegerArgs(Outs, IsInternal)) {
     errs() << "ERROR: Missing extension attribute of passed "
-           << "value in call to function:\n" << "Callee:  ";
+           << "value in call to function:\n"
+           << "Callee:  ";
     if (CalleeFn != nullptr)
       printFunctionArgExts(CalleeFn, errs());
     else
@@ -9869,9 +9870,8 @@ verifyNarrowIntegerArgs_Call(const SmallVectorImpl<ISD::OutputArg> &Outs,
   }
 }
 
-void SystemZTargetLowering::
-verifyNarrowIntegerArgs_Ret(const SmallVectorImpl<ISD::OutputArg> &Outs,
-                            const Function *F) const {
+void SystemZTargetLowering::verifyNarrowIntegerArgs_Ret(
+    const SmallVectorImpl<ISD::OutputArg> &Outs, const Function *F) const {
   if (!verifyNarrowIntegerArgs(Outs, isFullyInternal(F))) {
     errs() << "ERROR: Missing extension attribute of returned "
            << "value from function:\n";
@@ -9882,9 +9882,8 @@ verifyNarrowIntegerArgs_Ret(const SmallVectorImpl<ISD::OutputArg> &Outs,
 
 // Verify that narrow integer arguments are extended as required by the ABI.
 // Return false if an error is found.
-bool SystemZTargetLowering::
-verifyNarrowIntegerArgs(const SmallVectorImpl<ISD::OutputArg> &Outs,
-                        bool IsInternal) const {
+bool SystemZTargetLowering::verifyNarrowIntegerArgs(
+    const SmallVectorImpl<ISD::OutputArg> &Outs, bool IsInternal) const {
   if (IsInternal || !Subtarget.isTargetELF())
     return true;
 
@@ -9905,8 +9904,8 @@ verifyNarrowIntegerArgs(const SmallVectorImpl<ISD::OutputArg> &Outs,
     if (VT.isInteger()) {
       assert((VT == MVT::i32 || VT.getSizeInBits() >= 64) &&
              "Unexpected integer argument VT.");
-      if (VT == MVT::i32 &&
-          !Flags.isSExt() && !Flags.isZExt() && !Flags.isNoExt())
+      if (VT == MVT::i32 && !Flags.isSExt() && !Flags.isZExt() &&
+          !Flags.isNoExt())
         return false;
     }
   }

``````````

</details>


https://github.com/llvm/llvm-project/pull/109699


More information about the llvm-commits mailing list