[llvm] [SystemZ][z/OS] fix sample-split-layout.test on z/OS (PR #109679)

via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 23 08:59:18 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-pgo

Author: Zibi Sarbinowski (zibi2)

<details>
<summary>Changes</summary>

The Lit in subject fails on z/OS since the input file `Inputs/split-layout.profdata` is marked as ASCII even though it is binary and the output file `Output/sample-split-layout.test.tmp-output` is binary. 

This PR removes the diff command which fails because it compares a binary file and a text file. The rational is that this diff command seems to be redundant to the `FileCheck` on the next command.

---
Full diff: https://github.com/llvm/llvm-project/pull/109679.diff


1 Files Affected:

- (modified) llvm/test/tools/llvm-profdata/sample-split-layout.test (-1) 


``````````diff
diff --git a/llvm/test/tools/llvm-profdata/sample-split-layout.test b/llvm/test/tools/llvm-profdata/sample-split-layout.test
index a1927c80b2e29b..51091e9f25c02d 100644
--- a/llvm/test/tools/llvm-profdata/sample-split-layout.test
+++ b/llvm/test/tools/llvm-profdata/sample-split-layout.test
@@ -1,5 +1,4 @@
 RUN: llvm-profdata merge --sample --extbinary --split-layout %p/Inputs/sample-profile.proftext -o %t-output
-RUN: diff %t-output %p/Inputs/split-layout.profdata
 
 RUN: llvm-profdata merge --sample --text --split-layout %t-output | FileCheck %s
 CHECK: main:184019:0

``````````

</details>


https://github.com/llvm/llvm-project/pull/109679


More information about the llvm-commits mailing list